This repository was archived by the owner on Dec 7, 2021. It is now read-only.
fix: Revert horizontal asset bar - #881
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #881 +/- ##
===========================================
- Coverage 88.15% 87.79% -0.36%
===========================================
Files 130 130
Lines 4878 4876 -2
Branches 903 903
===========================================
- Hits 4300 4281 -19
- Misses 576 593 +17
Partials 2 2
Continue to review full report at Codecov.
|
Wallace Breza (wbreza)
requested review from
Elizabeth Halper (elizabethhalper) and
My (mydiemho)
August 24, 2019 03:11
Tanner Barlow (tbarlow12)
self-requested a review
August 26, 2019 15:00
Tanner Barlow (tbarlow12)
approved these changes
Aug 26, 2019
Phil (PIC123)
approved these changes
Aug 26, 2019
Phil (PIC123)
left a comment
Phil (PIC123)
left a comment
Contributor
There was a problem hiding this comment.
lgtm, would be nice to see if we can figure out a way to allow for other layouts
My (mydiemho)
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The horizontal asset bar looks more visually appealing on the bottom and it also opens up more real estate for the main editing surface.
However, it also reduces the overall usability of the app. The vertical scrolling behavior on the moues wheel no longer works and the keyboard shortcut hot keys are inverted.
Let's revert this change for now until we are able to overcome these critical usability requirements.